During his diving career, Eric Macdonald was a member of the Penguin, Stoke Newington Institute, and Southern clubs, and was also a member of the Amateur Diving Association (ADA) coaching team. He won nine ADA titles and was a podium-finisher on many more occasions. He won his first titles in 1924, when he captured both the high fancy diving and springboard titles. He retained the springboard title in 1925 and the following year Macdonald won the springboard, high fancy, and plain diving titles. He won the springboard title for the fourth consecutive year in 1927, when he also won the high fancy title for the third time. His ninth and last title was in 1933 when he once again won the springboard title. Internationally, Macdonald appeared at the 1927 European Championships in Bologna, and the 1924 Paris Olympics, when he was one of just six men to compete in both diving events.